Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LU LSP bugs #2046

Closed
2 of 7 tasks
vishwacsena opened this issue Feb 21, 2020 · 1 comment
Closed
2 of 7 tasks

LU LSP bugs #2046

vishwacsena opened this issue Feb 21, 2020 · 1 comment
Assignees
Labels
R8 Release 8 - March 16th, 2020 Type: Bug Something isn't working
Projects

Comments

@vishwacsena
Copy link
Contributor

Describe the bug

In playing with the auto-suggest, auto-complete capabilities for LU, I ran into the following issues -

  1. Picking from the entity type (list) adds the entity type without a space and the parser complains of no space. We should not auto-complete content that will result in known parser errors.
repro: 
1. Type '@' and wait for the entity type auto-suggest UI
2. Pick list entity type 
  1. Adding sub-lists in list entity definition is missing space after ‘-‘
repro:
1. Type '@ list city = ' and hit enter. Notice '- ' auto-complete for normalized value.
2. Type 'seattle : ' and hit enter
3. Notice we no longer offer auto-complete '- ' with appropriate indentation for sub-lists
  1. Hyphen stops working on new utterances on new intent added after entity definition
repro:
1. Add an intent section - e.g. 
# greeting 
- hello
2. Then add an entity definition - e.g. 
@ ml testEntity
3. Then add another intent section - e.g. '# testIntent' and hit enter
4. Notice the auto-complete for '- ' no longer works.
  1. No hyphen auto-inserted after @ phraselist todoItem =
repro:
1. Type '@ phraselist test = ' and hit enter. We should auto-complete each line with '- ', this is just a list of values similar to intent definition. 
  1. No auto-suggest for (interchangeable) for phrase list

repro: 
1. Type ' @ phraselist test(' 
We should offer auto-complete for '@ phraselist test(interchangeable)'

Version

Browser

  • Chrome
  • Safari
  • Firefox
  • Edge

OS

  • macOS
  • Windows
  • Ubuntu
@vishwacsena vishwacsena added the Needs-triage A new issue that require triage label Feb 21, 2020
@hibrenda hibrenda added R8 Release 8 - March 16th, 2020 Type: Bug Something isn't working and removed Needs-triage A new issue that require triage labels Feb 24, 2020
@hibrenda hibrenda added this to To do in Sprint 22 via automation Feb 24, 2020
@hibrenda hibrenda moved this from To do to In progress in Sprint 22 Feb 27, 2020
@cwhitten
Copy link
Member

addressed via #2046

Sprint 22 automation moved this from In progress to Done Feb 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
R8 Release 8 - March 16th, 2020 Type: Bug Something isn't working
Projects
No open projects
Sprint 22
  
Done
Development

No branches or pull requests

4 participants