Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Accessibility][Name, Role, Value - Notification]: Ensures every ARIA input field has an accessible name #2123

Closed
ShellySoni opened this issue Feb 28, 2020 · 2 comments

Comments

@ShellySoni
Copy link

ShellySoni commented Feb 28, 2020

User Experience:
This issue should be resolved for good coding practice as all ARIA input field must has an accessible name.

Test Environment:
Environment: Chromium Edge (Anaheim) + Narrator
Build Version: 2004 (OS Build 19564.1005)​​
Microsoft Edge Version: 82.0.425.0 (Official build) canary (64-bit)​
Test URL: http://localhost:3000/home

Repro Steps:

  1. Open URL: http://localhost:3000/home
  2. "Bot Framework Composer" homepage will gets opened.
  3. Select any of the previously created bot from "Recent Bots" or create one from the available Bots under 'Examples' and activate it.
  4. Select 'Notification' from left navigation.
  5. Run K4W tool on the page and Observe the issue.

Actual Result:
ARIA input field i.e. 'All' does not has an accessible name. Screen reader read only like : All selected, selection between three items'.

This accessibility issue was found using Accessibility Insights for Web(keros), a tool that helps debug and find accessibility issues earlier. Get more information & download this tool at http://aka.ms/Keros.

Expected Result:
Ensures every ARIA input field has an accessible name. Screen reader should read like : Notification_All button selected, selection between three items'.

MAS Reference:
https://microsoft.sharepoint.com/:w:/r/teams/msenable/_layouts/15/WopiFrame.aspx?sourcedoc={248054a6-5e68-4771-9e1e-242fb5025730}

Attachment:
MAS4.1.2_Notification_All Button.zip

@corinagum
Copy link
Contributor

MAS4 1 2_Notification_All Button
MAS4 1 2_Notification_All Button_K4W

@cwhitten cwhitten removed the Needs-triage A new issue that require triage label Feb 29, 2020
@cwhitten cwhitten added the Fixed label Mar 12, 2020
@cwhitten cwhitten moved this from To do - Shell (Ben, Leilei) to Waiting for verification in BUILD '20 a11y Mar 12, 2020
@ashish315
Copy link

As checked and verified on below environment, the issue is fixed now. So, we are closing the issue.

Test Environment
Browser: Microsoft Edge Dev {Version 83.0.467.0 (Official build) dev (64-bit)}
OS build: 2004 (19588.1000)
Screen Reader: Narrator
URL: Bot Framework Composer
Prerequisite Here

@cwhitten cwhitten moved this from Waiting for verification to Done in BUILD '20 a11y Apr 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

No branches or pull requests

6 participants