Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

a11y: Accessibility issue #2197

Merged
merged 6 commits into from
Mar 12, 2020
Merged

a11y: Accessibility issue #2197

merged 6 commits into from
Mar 12, 2020

Conversation

liweitian
Copy link
Contributor

@liweitian liweitian commented Mar 8, 2020 •
edited by a-b-r-o-w-n
Loading

Description

Task Item

refs #2143
refs #2123

Screenshots

微信图片_20200308230924

@liweitian liweitian changed the base branch from stable to master March 8, 2020 15:10
@liweitian liweitian changed the title ally: fix Accessibility issue ally: Accessibility issue Mar 8, 2020
@liweitian liweitian changed the title ally: Accessibility issue a11y: Accessibility issue Mar 8, 2020
corinagum
corinagum approved these changes Mar 10, 2020
View reviewed changes
Copy link
Contributor

@corinagum corinagum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :)

@cwhitten cwhitten merged commit fd37ebf into microsoft:master Mar 12, 2020
@a-b-r-o-w-n a-b-r-o-w-n mentioned this pull request Mar 18, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DesignPolice DesignPolice DesignPolice left review comments

@a-b-r-o-w-n a-b-r-o-w-n a-b-r-o-w-n approved these changes

@corinagum corinagum corinagum approved these changes

@benbrown benbrown Awaiting requested review from benbrown

@boydc2014 boydc2014 Awaiting requested review from boydc2014 boydc2014 is a code owner

@cwhitten cwhitten Awaiting requested review from cwhitten cwhitten is a code owner

@luhan2017 luhan2017 Awaiting requested review from luhan2017

@yeze322 yeze322 Awaiting requested review from yeze322

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@liweitian @a-b-r-o-w-n @corinagum @DesignPolice @cwhitten