Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Accessibility][Bypass Blocks - Property Pane]: Ensure frame must have tittle attribute. #2143

Closed
ashish315 opened this issue Mar 2, 2020 · 5 comments

Comments

@ashish315
Copy link

ashish315 commented Mar 2, 2020

User Experience
Frame title should be define properly so that user can get the information of control.

Test Environment
Browser: Microsoft Edge Canary Version: 82.0.425.0 (Official build)
OS build: 2004 (19564.1005)
URL: Bot Framework Composer
Prerequisite Here

Repro Steps:

  1. Open the above mentioned URL in EDGE.
  2. "Bot Framework Composer" homepage will gets opened.
  3. Select any of the previously created bot from "Recent Bots" or create one from the available Bots under 'Examples' and activate it.
  4. Navigate to already created dialog tree item and activate it. Such as- Greetings, Actions, EndDialog etc.
  5. Click on "+" and select 'Ask a question'. Then select any of the available options except Oauth login.
  6. Navigate to property pane appeared at right side of the screen and select 'Bot Asks'.
  7. Run Accessibility insight and observe the issue.

Actual:
Adaptive property frame doesn't contain any tittle attribute.

Expected:
Ensures <iframe> and elements contain a non-empty title attribute.

Note:
This accessibility issue was found using Accessibility Insights for Web 2.14.1 (axe-core 3.3.2), a tool that helps find and fix accessibility issues. Get more information & download this tool at http://aka.ms/AccessibilityInsights.

Element path
.css-vaviek

Snippet
<iframe name="FormEditor" src="/extensionContainer.html" class="css-vaviek"></iframe>

How to fix
Fix any of the following:
aria-label attribute does not exist or is empty
aria-labelledby attribute does not exist, references elements that do not exist or references elements that are empty
Element has no title attribute or the title attribute is empty
Element's default semantics were not overridden with role="presentation"
Element's default semantics were not overridden with role="none"

Note
Same issue observed throughout the website for every property pane as well as the flow design.

MAS Impacted: MAS2.4.1

Attachment:
frame tittle
Bypass block
Bypass block property pane

@cwhitten cwhitten removed the Needs-triage A new issue that require triage label Mar 2, 2020
@cwhitten cwhitten added this to To do - Forms (TJ/Ben) in BUILD '20 a11y Mar 10, 2020
@cwhitten cwhitten added the Fixed label Mar 12, 2020
@cwhitten cwhitten moved this from To do - Forms (TJ, Ben) to Waiting for verification in BUILD '20 a11y Mar 12, 2020
@ashish315
Copy link
Author

@cwhitten As validated, some issue's are fixed but some are still repro. If you want, we can log separate bug for the same and close this bug.
Issue still repro-

  1. Ensures each page has at least one mechanism for a user to bypass navigation and jump straight to the content.

@ashish315 ashish315 removed the Fixed label Apr 4, 2020
@corinagum
Copy link
Contributor

@ashish315 for clarity, I think it would be great if you could file a new issue. Once you do, please add the link here so we don't miss anything.

I'll close this as resolved once the new issue is filed. Thank you!

@ashish315
Copy link
Author

@corinagum Please find the bug Id of new bug filled for the above issue.
[Accessibility][Bypass Blocks - Design Flow]: Ensures each page has at least one mechanism for a user to bypass navigation and jump straight to the content at property pane. #2538

@cwhitten
Copy link
Member

cwhitten commented Apr 7, 2020

Thank you @ashish315. Please close this one.

@cwhitten cwhitten added the Fixed label Apr 7, 2020
@ashish315
Copy link
Author

Closing the bug as per developer comment.

@a-b-r-o-w-n a-b-r-o-w-n moved this from Waiting for verification to Done in BUILD '20 a11y Apr 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

No branches or pull requests

5 participants