Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot run 'update-schema' after runtime updating to '4.12.0-daily*' #5576

Closed
2 of 8 tasks
yeze322 opened this issue Jan 21, 2021 · 2 comments
Closed
2 of 8 tasks

Cannot run 'update-schema' after runtime updating to '4.12.0-daily*' #5576

yeze322 opened this issue Jan 21, 2021 · 2 comments
Assignees
@GeoffCoxMSFT
Labels
Type: Bug Something isn't working
Projects
R12 - Work items
Milestone
R12

Comments

@yeze322
Copy link
Contributor

yeze322 commented Jan 21, 2021 •
edited

Describe the bug

Problem

Cannot run the update-schema script under the schemas/ folder after ejected the runtime instance.
It will fail silently:
image

Cause

In #5529 , runtime's dependencies were updated to 4.12.0-daily*, it caused the update-schema.sh script cannot reference the exact pacakge given the asterisk wildcard.

Workaround

Replace all appearances of 4.12.0-daily* to 4.12.0-daily (without *) accross all csproj files can bypass this issue.
image

For a long term fix, we may need to update the source code bf dialog:merge command to match package names with asterisk.

Version

Browser

  • Electron distribution
  • Chrome
  • Safari
  • Firefox
  • Edge

OS

  • macOS
  • Windows
  • Ubuntu
@yeze322 yeze322 added Type: Bug Something isn't working Needs-triage A new issue that require triage labels Jan 21, 2021
@yeze322 yeze322 changed the title "update-schema" failed after runtime migrating to 4.12.0-daily "update-schema" failed after runtime migrating to '4.12.0-daily*' Jan 21, 2021
@yeze322 yeze322 changed the title "update-schema" failed after runtime migrating to '4.12.0-daily*' Cannot run 'update-schema' after runtime updating to '4.12.0-daily*' Jan 21, 2021
@srinaath srinaath removed the Needs-triage A new issue that require triage label Jan 21, 2021
@srinaath srinaath added this to the R12 milestone Jan 21, 2021
@GeoffCoxMSFT
Copy link
Member

I tried putting the references without the wildcard, but a nuget restore will mismatch and try to resolve its "best guess" which happens to be an ancient version from back in Oct. 2020. I'll go look at the bf-merge code.

@chrimc62 chrimc62 mentioned this issue Jan 27, 2021
Merged
@chrimc62
Copy link
Contributor

Resolved by microsoft/botframework-cli#1096

@cwhitten cwhitten added this to Done in R12 - Work items Feb 2, 2021
@cwhitten cwhitten moved this from Done to In nightly in R12 - Work items Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GeoffCoxMSFT GeoffCoxMSFT

Labels
Type: Bug Something isn't working
Projects
R12 - Work items
In nightly
Milestone
R12
Development

No branches or pull requests
4 participants
@yeze322 @srinaath @chrimc62 @GeoffCoxMSFT