Support wild cards in nuget versions for dialog:merge #1096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrimc62
requested review from
cleemullins,
joshgummersall and
munozemilio
as code owners
joshgummersall
approved these changes
Jan 27, 2021
| @@ -1069,18 +1094,27 @@ export class SchemaMerger { | |||
| for (const pkgVersion of await fs.readdir(pkgPath)) { | |||
| versions.push(pkgVersion.toLowerCase()) | |||
| } | |||
| // NOTE: The semver package does not handle more complex nuget range revisions | |||
| // We get an exception and will ignore those dependencies. | |||
| let versionToUse: any | |||
There was a problem hiding this comment.
any should almost always be avoided if possible. #Resolved
| if (this.debug) { | ||
| this.parsingWarning(`Using most recent version ${minVersion}`) | ||
| } | ||
| } else if (minVersion.includes('*')) { | ||
| // Match pattern against available versions | ||
| let pattern = this.nugetPattern(minVersion) |
| @@ -1055,6 +1056,30 @@ export class SchemaMerger { | |||
| } | |||
| } | |||
|
|
|||
| // Convert a nuget pattern to a regexp | |||
There was a problem hiding this comment.
A comment that includes a few examples of nuget versions and the expected RegExp could be helpful. #Resolved
| @@ -39,7 +39,7 @@ | |||
| </PropertyGroup> | |||
|
|
|||
| <ItemGroup> | |||
| <PackageReference Include="nuget1" Version="10.0.0" /> | |||
| <PackageReference Include="nuget1" Version="10.*" /> | |||
There was a problem hiding this comment.
Could be worth putting in some with * in other version parts plus having the format from the daily builds where there is more text in different parts. example: 4.12.0-daily.* #WontFix
GeoffCoxMSFT
approved these changes
Jan 27, 2021
joshgummersall
approved these changes
Jan 27, 2021
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes composer bug: microsoft/BotFramework-Composer#5576 by adding support for matching nuget versions with * by building a regex and matching against the file path names.