Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing a package in the Package Manager appears to hang #6650

Closed
2 of 8 tasks
beyackle opened this issue Apr 1, 2021 · 3 comments
Closed
2 of 8 tasks

Removing a package in the Package Manager appears to hang #6650

beyackle opened this issue Apr 1, 2021 · 3 comments
Assignees
Labels
P1 Painful if we don't fix, won't block releasing Type: Bug Something isn't working
Milestone

Comments

@beyackle
Copy link
Contributor

beyackle commented Apr 1, 2021

Describe the bug

Uninstalling a package causes the "Removing package" message box to pop up, but it doesn't go away. The package does get removed, and reloading the page works to solve the apparent hang (showing the removed package). The crash happens inside the catch block of Library.tsx at line 509 where it's trying to read err.response.status when the error object doesn't have a response field, but I don't know how we want to expose non-HTTP-related errors to a user.

Version

1.4.0

Browser

  • Electron distribution
  • Chrome
  • Safari
  • Firefox
  • Edge

OS

  • macOS
  • Windows
  • Ubuntu

To Reproduce

Steps to reproduce the behavior:

  1. Go to the Package manager
  2. Install a package
  3. Remove it

Expected behavior

The "removing package" message should go away once the package is removed, as expected.

Screenshots

image

@beyackle beyackle added Type: Bug Something isn't working Needs-triage A new issue that require triage labels Apr 1, 2021
@benbrown benbrown self-assigned this Apr 1, 2021
@benbrown benbrown added this to the R13 milestone Apr 1, 2021
@srinaath srinaath removed the Needs-triage A new issue that require triage label Apr 6, 2021
@cwhitten cwhitten added the P1 Painful if we don't fix, won't block releasing label Apr 21, 2021
@cwhitten
Copy link
Member

I'm unable to repro.

@benbrown
Copy link
Contributor

Not sure how to repro this, but I added some checks on that undefined object in #7243 that should prevent this.

@benbrown
Copy link
Contributor

Should be fixed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 Painful if we don't fix, won't block releasing Type: Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants