Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NodeJS bot fails to start on windows #8287

Closed
2 of 8 tasks
Brent-Higgins opened this issue Jul 7, 2021 · 1 comment · Fixed by #8297
Closed
2 of 8 tasks

NodeJS bot fails to start on windows #8287

Brent-Higgins opened this issue Jul 7, 2021 · 1 comment · Fixed by #8297
Assignees
Labels
Bot Services Required for internal Azure reporting. Do not delete. Do not change color. customer-replied-to Required for internal reporting. Do not delete. customer-reported Required for internal Azure reporting. Do not delete. R14 Team: Runtime & Publishing Type: Bug Something isn't working
Milestone

Comments

@Brent-Higgins
Copy link

Describe the bug

On Windows when we try to start a bot the bot fails to start with a SIGTERM error from npm install.
This occurs due to additional packages in package.json to facilitate CI/CD requirements causes npm install to take 90+ seconds.

Version

Version: 2.0.0
Electron: 8.2.4
Chrome: 80.0.3987.165
NodeJS: 12.13.0
V8: 8.0.426.27-electron.0

Browser

  • Electron distribution
  • Chrome
  • Safari
  • Firefox
  • Edge

OS

  • macOS
  • Windows
  • Ubuntu

To Reproduce

Steps to reproduce the behavior:

  1. modify package.json to include the following
 "dependencies": {
    "@microsoft/botframework-cli": "^4.12.0-dev.20210115.2b00408",
    "botbuilder-ai-luis": "4.13.4-preview",
    "botbuilder-ai-qna": "4.13.4-preview",
    "botbuilder-dialogs-adaptive-runtime": "4.13.4-preview",
    "botbuilder-dialogs-adaptive-runtime-integration-express": "4.13.4-preview",
    "cross-env": "latest",
    "sonarqube-scanner": "^2.8.0"
  },
  "devDependencies": {
    "@types/chai": "^4.2.18",
    "@types/mocha": "^8.2.2",
    "@types/sinon": "^10.0.2",
    "botium-bindings": "^2.1.8",
    "botium-connector-directline3": "0.0.26",
    "chai": "^4.3.4",
    "dotenv": "^10.0.0",
    "mocha": "^9.0.0",
    "mochawesome": "^6.2.2",
    "nyc": "^15.1.0",
    "sinon": "^11.1.1",
    "ts-node": "^10.0.0",
    "typescript": "^4.3.2"
  }
  1. click start bot

Expected behavior

Bot can start even if npm install is slow

Screenshots

Additional context

This is occurring on windows PCs behind an enterprise firewall using an internal npm artifactory mirror.
This is caused by 120 second timeout on bot start that is hardcoded into composer.
On Mac our npm install is taking ~30 seconds on windows it is taking >=90 seconds.
We can start the bot in cmd prompt.
Running npm install in the repo manually does not solve the issue.
Access to public npm is blocked by corporate policy.
We can usually get the bot to start if we do not have the extra dependencies.
With above configuration 100% reproduction rate across multiple computers on VPN and corporate network.

@Brent-Higgins Brent-Higgins added Needs-triage A new issue that require triage Type: Bug Something isn't working labels Jul 7, 2021
@stevkan stevkan added Bot Services Required for internal Azure reporting. Do not delete. Do not change color. customer-reported Required for internal Azure reporting. Do not delete. labels Jul 8, 2021
@a-b-r-o-w-n a-b-r-o-w-n added R14 and removed Needs-triage A new issue that require triage labels Jul 8, 2021
@a-b-r-o-w-n
Copy link
Contributor

@Brent-Higgins thanks for the report. We will increase the timeout for our upcoming release.

@axelsrz axelsrz added the customer-replied-to Required for internal reporting. Do not delete. label Jul 8, 2021
@axelsrz axelsrz added this to the R14 milestone Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bot Services Required for internal Azure reporting. Do not delete. Do not change color. customer-replied-to Required for internal reporting. Do not delete. customer-reported Required for internal Azure reporting. Do not delete. R14 Team: Runtime & Publishing Type: Bug Something isn't working
Projects
None yet
5 participants