Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: extend timeout length from 2 minutes to 5 minutes for npm install #8297

Merged
merged 3 commits into from Jul 8, 2021

Conversation

benbrown
Copy link
Contributor

@benbrown benbrown commented Jul 8, 2021

Description

Users with slower internet connections or proxy rules in place reported that the npm install step during the build/run process was taking longer than 2 minutes, thus timing out.

This PR increases this timeout length to 5 minutes. We will also need to follow up to see what takes so long for some users...

Task Item

Fixes #8287

@benbrown benbrown added this to the R14 milestone Jul 8, 2021
@a-b-r-o-w-n a-b-r-o-w-n self-assigned this Jul 8, 2021
@a-b-r-o-w-n a-b-r-o-w-n merged commit d9bc42f into main Jul 8, 2021
@a-b-r-o-w-n a-b-r-o-w-n deleted the benbrown/longertimeout branch July 8, 2021 20:03
@coveralls
Copy link

coveralls commented Jul 8, 2021

Coverage Status

Coverage remained the same at 56.425% when pulling 70da742 on benbrown/longertimeout into e75e02a on main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NodeJS bot fails to start on windows
3 participants