Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: C# template build failure after copied to a new bot folder #1578

Merged
merged 2 commits into from Nov 15, 2019

Conversation

luhan2017
Copy link
Contributor

@luhan2017 luhan2017 commented Nov 14, 2019

Description

Disable StyleCop Rule : SA1412: StoreFilesAsUtf8BOM

This rule needs all files be UTF8BOM format. But when we copy bot template to new created bot folder, it will be saved as UTF8 defaultly. This pr is to disable this rule to fix that issue.

Task Item

fixes #1577

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code refactor (non-breaking change which improve code quality, clean up, add tests, etc)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Doc update (document update)

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have functionally tested my change

Screenshots

Please include screenshots or gifs if your PR include UX changes.

@luhan2017 luhan2017 changed the title Update BotProject.ruleset Fix: C# template build failure after copied to a new bot folder Nov 14, 2019
@luhan2017 luhan2017 changed the title Fix: C# template build failure after copied to a new bot folder fix: C# template build failure after copied to a new bot folder Nov 14, 2019
@cwhitten cwhitten merged commit 4cae3da into master Nov 15, 2019
@a-b-r-o-w-n a-b-r-o-w-n deleted the luhan/stylecopfix branch April 8, 2020 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants