Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: support horizontal scrolling in visual eidtor #1607

Merged
merged 3 commits into from
Nov 25, 2019
Merged

fix: support horizontal scrolling in visual eidtor #1607

merged 3 commits into from
Nov 25, 2019

Conversation

alanlong9278
Copy link
Contributor

@alanlong9278 alanlong9278 commented Nov 20, 2019 •
edited

Description

  • Upgrade Fabric Ui package to fix marqueeSelection horizontal scrolling function.
  • Add webpack-cli package to visual editor

Task Item

closes #1365

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code refactor (non-breaking change which improve code quality, clean up, add tests, etc)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Doc update (document update)

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have functionally tested my change

Screenshots

scroll

@alanlong9278 alanlong9278 changed the base branch from stable to master November 20, 2019 11:52
@alanlong9278 alanlong9278 changed the title Fix: support horizontal scrolling in visual eidtor fix: support horizontal scrolling in visual eidtor Nov 21, 2019
@github-actions
Copy link

Coverage Status

Coverage remained the same at 39.819% when pulling 90ff910 on julong/marqueeSelectionHorizontalScroll into f0ebe56 on master.

a-b-r-o-w-n
a-b-r-o-w-n previously requested changes Nov 21, 2019
View reviewed changes
Copy link
Contributor

@a-b-r-o-w-n a-b-r-o-w-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update fabric in all packages? I want to lock the version across all packages so we are always in sync. Thanks.

@alanlong9278 alanlong9278 force-pushed the julong/marqueeSelectionHorizontalScroll branch from 43e2aea to 9291ecd Compare November 25, 2019 03:56
@alanlong9278
Copy link
Contributor Author

Can you update fabric in all packages? I want to lock the version across all packages so we are always in sync. Thanks.

Have Updated fabrci in all packages @a-b-r-o-w-n

@cwhitten cwhitten merged commit 9e70664 into master Nov 25, 2019
@cwhitten cwhitten deleted the julong/marqueeSelectionHorizontalScroll branch November 25, 2019 05:34
@cwhitten cwhitten mentioned this pull request Nov 25, 2019
Closed
@a-b-r-o-w-n a-b-r-o-w-n mentioned this pull request Dec 11, 2019
Merged
@a-b-r-o-w-n a-b-r-o-w-n mentioned this pull request Dec 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwhitten cwhitten cwhitten approved these changes

@a-b-r-o-w-n a-b-r-o-w-n a-b-r-o-w-n left review comments

@benbrown benbrown Awaiting requested review from benbrown

@boydc2014 boydc2014 Awaiting requested review from boydc2014 boydc2014 is a code owner

@luhan2017 luhan2017 Awaiting requested review from luhan2017

@yeze322 yeze322 Awaiting requested review from yeze322

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alanlong9278 @cwhitten @a-b-r-o-w-n