Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: make docker great again #1709

Merged
merged 9 commits into from Dec 6, 2019
Merged

build: make docker great again #1709

merged 9 commits into from Dec 6, 2019

Conversation

a-b-r-o-w-n
Copy link
Contributor

closes #1669

@github-actions
Copy link

github-actions bot commented Dec 6, 2019

Coverage Status

Coverage increased (+0.03%) to 40.897% when pulling 63b77c1 on docker-updates into 9d93ad8 on master.

@cwhitten cwhitten merged commit 01cd533 into master Dec 6, 2019
@cwhitten cwhitten deleted the docker-updates branch December 6, 2019 03:07
@cwhitten
Copy link
Member

cwhitten commented Dec 6, 2019

MDGA!

@cwhitten cwhitten mentioned this pull request Dec 6, 2019
Closed
1 task
@boydc2014
Copy link
Contributor

boydc2014 commented Dec 6, 2019 •
edited

Hey @a-b-r-o-w-n, looks like i left comments in the previous PR #1708 (comment)

It fails on my side to create bot from templates in docker run. Can you double-check on you side?

@liweitian looks like it's related to templateId, can you also help verify on your side?

@liweitian
Copy link
Contributor

@boydc2014 @a-b-r-o-w-n runtimeFolder: Path.resolve('../../../BotProject/Templates'), in docker the runtimeFolder is app/BotProject/Template. But the folder 'Botproject' was copied to /
I think there is something wrong in the dockerfile. I am still investigating it.

@a-b-r-o-w-n
Copy link
Contributor Author

a-b-r-o-w-n commented Dec 6, 2019 •
edited

@boydc2014 @liweitian I will check on this today. Thanks for taking a look!

@a-b-r-o-w-n a-b-r-o-w-n mentioned this pull request Dec 11, 2019
Merged
@a-b-r-o-w-n a-b-r-o-w-n mentioned this pull request Dec 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwhitten cwhitten cwhitten approved these changes

@boydc2014 boydc2014 Awaiting requested review from boydc2014 boydc2014 is a code owner

@luhan2017 luhan2017 Awaiting requested review from luhan2017

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@a-b-r-o-w-n @cwhitten @boydc2014 @liweitian