Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Moved field descriptions into tooltip #1858

Merged
merged 6 commits into from
Feb 3, 2020
Merged

fix: Moved field descriptions into tooltip #1858

merged 6 commits into from
Feb 3, 2020

Conversation

tdurnford
Copy link
Collaborator

@tdurnford tdurnford commented Jan 14, 2020 •
edited
Loading

Description

Some descriptions in the form editor were written inline instead of being contained in a description callout. Updated the BaseField component to use the WidgetLabel to resolve the issue.

Task Item

Closes #1830

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have functionally tested my change

Screenshots

Before

image

After

image

@tdurnford tdurnford changed the title Moved field descriptions into tooltip fix: Moved field descriptions into tooltip Jan 14, 2020
@tdurnford tdurnford closed this Jan 17, 2020
@tdurnford tdurnford reopened this Jan 28, 2020
a-b-r-o-w-n
a-b-r-o-w-n requested changes Jan 29, 2020
View reviewed changes
Copy link
Contributor

@a-b-r-o-w-n a-b-r-o-w-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is also failing CI.

Composer/packages/extensions/obiformeditor/src/Form/fields/BaseField.tsx Outdated Show resolved Hide resolved
@a-b-r-o-w-n a-b-r-o-w-n merged commit 983b29e into microsoft:master Feb 3, 2020
@tdurnford tdurnford mentioned this pull request Feb 6, 2020
Closed
@a-b-r-o-w-n a-b-r-o-w-n mentioned this pull request Feb 21, 2020
Merged
@tdurnford tdurnford deleted the 1830 branch February 24, 2020 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a-b-r-o-w-n a-b-r-o-w-n a-b-r-o-w-n approved these changes

@boydc2014 boydc2014 Awaiting requested review from boydc2014 boydc2014 is a code owner

@cwhitten cwhitten Awaiting requested review from cwhitten cwhitten is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tdurnford @a-b-r-o-w-n