Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update framework and package version in template botproject #1939

Merged
merged 15 commits into from
Feb 13, 2020

Conversation

VanyLaw
Copy link
Contributor

@VanyLaw VanyLaw commented Feb 4, 2020

Description

Cause: The original version package reference was remove from repo, and caused sample bot project build failed.
Solution:

  • update package reference in template botproject
  • update schema to match the new version sdk
  • change the script to throw error sothat the process can catch it.
  • update netcoreapp form 2.1 to 3.1

And @alanlong9278 will help to fix the UI to match schema change(number to expression).

FYI. those sdk main changes:

  1. New recognizers set:
  • Microsoft.AdaptiveCardRecognizer
  • Microsoft.QnAMakerRecognizer
  • Microsoft.CrossTrainedRecognizerSet
  • Microsoft.RecognizerSet
  • Microsoft.OnChooseIntent (trigger)
  • Microsoft.OnQnAMatch (trigger)
  1. FormDialog related triggers and actions
  • Microsoft.Ask
  • Microsoft.OnAssignEntity
  • Microsoft.OnChooseEntity
  • Microsoft.OnChooseProperty
  • Microsoft.OnClearProperty
  1. Other new actions and triggers
  • Microsoft.GotoAction
  • Microsoft.ContinueLoop
  • Microsoft.BreakLoop
  • Microsoft.UpdateActivity
  • Microsoft.DeleteActivity
  • Microsoft.GetActivityMembers
  • Microsoft.GetConversationMembers
  • Microsoft.SignOutUser
  • Microsoft.OnEndOfActions
  1. minor updates
  • Add disabled property on actions
  • Change includeActivity to activityProcessed (only this one have a breaking change, but we don't enabled it in Composer UX yet, so this is fine.)

There is only one breaking change in the schema, others are all additions.

Task Item

fixes #1927

Screenshots

@github-actions
Copy link

github-actions bot commented Feb 4, 2020

Coverage Status

Coverage remained the same at 42.425% when pulling 972202c on wenyluo/test into 983b29e on master.

@InDieTasten
Copy link

InDieTasten commented Feb 4, 2020

I've tried this on my local environment, and it did not resolve the issue.

I find it strange, that this is still running on target framework netcoreapp2.1. Wouldn't it make sense, to update to netcoreapp2.2 ?

EDIT: This resolves the issue, but I was getting build errors from a configured nuget source that failed. It's kind of annoying though, that the build errors can only be validated from running the build manually, and that composer wouldn't log the build errors to console. Makes reproducing and fixing a bit difficult.

@aalmada
Copy link

aalmada commented Feb 4, 2020

@VanyLaw
Copy link
Contributor Author

VanyLaw commented Feb 4, 2020

I've tried this on my local environment, and it did not resolve the issue.

I find it strange, that this is still running on target framework netcoreapp2.1. Wouldn't it make sense, to update to netcoreapp2.2 ?

EDIT: This resolves the issue, but I was getting build errors from a configured nuget source that failed. It's kind of annoying though, that the build errors can only be validated from running the build manually, and that composer wouldn't log the build errors to console. Makes reproducing and fixing a bit difficult.

If you want to update to netcoreapp2.2, you need to change the package references and add some extra reference, like this:
image
I am not sure will it cause other compatible issues. Need to investigate it. But .net core sdk 2.2 should compatible with netcoreapp2.1.

And I modify the script to get more build error message.

@aalmada
Copy link

aalmada commented Feb 4, 2020

I applied the changes from this PR to my local version and I confirm that it fixes the 'Start Bot' issue.

@boydc2014
Copy link
Contributor

@VanyLaw Can we take this chance to upgrade to 3.1 if possible, 3.1 is a LTS version, and i hope that could save us efforts a lot of time.

@luhan2017
Copy link
Contributor

@VanyLaw, could you also update the sdk.schema in the template and Composer folder, and test whether the template bots work correctly?

@VanyLaw VanyLaw changed the title fix: update package version in template botproject fix: update framework and package version in template botproject Feb 5, 2020
@VanyLaw
Copy link
Contributor Author

VanyLaw commented Feb 5, 2020

@VanyLaw, could you also update the sdk.schema in the template and Composer folder, and test whether the template bots work correctly?

Some sample bots will throw "must be an expression" error. Seems like number need to be changed to expression after schema updated. According to @alanlong9278 , It will cause hige UI change. Maybe we need a discussion about it.

* update the validation

* fix some comments

* update some logic
@boydc2014 boydc2014 added the Approved to merge approved, waiting to be merged label Feb 13, 2020
@cwhitten cwhitten merged commit 705a7f4 into master Feb 13, 2020
@cwhitten cwhitten deleted the wenyluo/test branch February 13, 2020 16:59
@a-b-r-o-w-n a-b-r-o-w-n mentioned this pull request Feb 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved to merge approved, waiting to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants