Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

a11y: Accessibility in lg/lu page #2265

Merged
merged 3 commits into from
Mar 14, 2020
Merged

a11y: Accessibility in lg/lu page #2265

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2bb30f1
auto focus to editor
zhixzhan Mar 13, 2020
8b3b5af
auto focus to new one
zhixzhan Mar 13, 2020
8073895
Merge branch 'master' into accessibility
cwhitten Mar 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Composer/packages/client/src/pages/language-generation/code-editor.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ const CodeEditor: React.FC<CodeEditorProps> = props => {

const hash = props.location?.hash ?? '';
const hashLine = querystring.parse(hash).L;
const line = Array.isArray(hashLine) ? +hashLine[0] : typeof hashLine === 'string' ? +hashLine : undefined;
const line = Array.isArray(hashLine) ? +hashLine[0] : typeof hashLine === 'string' ? +hashLine : 0;

const inlineMode = !!template;
const [content, setContent] = useState(template?.body || file?.content);
Expand All @@ -69,7 +69,7 @@ const CodeEditor: React.FC<CodeEditorProps> = props => {
};

useEffect(() => {
if (lgEditor && line !== undefined) {
if (lgEditor) {
window.requestAnimationFrame(() => {
lgEditor.revealLine(line);
lgEditor.focus();
Expand Down
4 changes: 4 additions & 0 deletions Composer/packages/client/src/pages/language-generation/table-view.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,8 @@ const TableView: React.FC<TableViewProps> = props => {

const activeDialog = dialogs.find(({ id }) => id === fileId);

const [focusedIndex, setFocusedIndex] = useState(0);

useEffect(() => {
if (!file || isEmpty(file)) return;

Expand Down Expand Up @@ -87,6 +89,7 @@ const TableView: React.FC<TableViewProps> = props => {
toTemplateName: resolvedName,
};
copyLgTemplate(payload);
setFocusedIndex(templates.length);
},
[templates, file]
);
Expand Down Expand Up @@ -229,6 +232,7 @@ const TableView: React.FC<TableViewProps> = props => {
<DetailsList
componentRef={listRef}
items={templates}
initialFocusedIndex={focusedIndex}
styles={{
root: {
overflowX: 'hidden',
Expand Down
4 changes: 2 additions & 2 deletions Composer/packages/client/src/pages/language-understanding/code-editor.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ const CodeEditor: React.FC<CodeEditorProps> = props => {

const hash = props.location?.hash ?? '';
const hashLine = querystring.parse(hash).L;
const line = Array.isArray(hashLine) ? +hashLine[0] : typeof hashLine === 'string' ? +hashLine : undefined;
const line = Array.isArray(hashLine) ? +hashLine[0] : typeof hashLine === 'string' ? +hashLine : 0;

const inlineMode = !!intent;
const [content, setContent] = useState(intent?.Body || file?.content);
Expand All @@ -66,7 +66,7 @@ const CodeEditor: React.FC<CodeEditorProps> = props => {
};

useEffect(() => {
if (luEditor && line !== undefined) {
if (luEditor) {
window.requestAnimationFrame(() => {
luEditor.revealLine(line);
luEditor.focus();
Expand Down