Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: composer crashed when delete the dialog #2290

Merged
merged 2 commits into from
Mar 17, 2020
Merged

fix: composer crashed when delete the dialog #2290

merged 2 commits into from
Mar 17, 2020

Conversation

lei9444
Copy link
Contributor

@lei9444 lei9444 commented Mar 17, 2020

Description

The referred lu files will add to client storage.
For the empty bot, the field may be undefined.

Task Item

refs #2288

Screenshots

@github-actions
Copy link

Coverage Status

Coverage decreased (-0.01%) to 40.95% when pulling 6d383b1 on lei9444:fixdelete into 7e53610 on microsoft:master.

@lei9444 lei9444 merged commit 97b9698 into microsoft:master Mar 17, 2020
@cwhitten cwhitten mentioned this pull request Mar 18, 2020
Closed
7 tasks
@a-b-r-o-w-n a-b-r-o-w-n mentioned this pull request Mar 18, 2020
Merged
@lei9444 lei9444 deleted the fixdelete branch April 14, 2020 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boydc2014 boydc2014 boydc2014 approved these changes

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n a-b-r-o-w-n is a code owner

@cwhitten cwhitten Awaiting requested review from cwhitten cwhitten is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lei9444 @boydc2014