Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Teaching bubble missing content #7764

Merged
merged 10 commits into from
May 22, 2021
Merged

fix: Teaching bubble missing content #7764

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
a9169a9
fix: Teaching bubble missing content
tdurnford May 11, 2021
6b70d0e
Fix item ref
tdurnford May 11, 2021
ec19d4a
Merge branch 'main' into durnford/fix/onboarding
beyackle May 13, 2021
2cee204
Merge branch 'main' into durnford/fix/onboarding
beyackle May 14, 2021
316d21e
Merge branch 'main' into durnford/fix/onboarding
beyackle May 14, 2021
e00f14e
Merge branch 'main' into durnford/fix/onboarding
tdurnford May 14, 2021
cddef3d
Merge branch 'main' into durnford/fix/onboarding
hatpick May 17, 2021
6a0396f
Merge branch 'main' into durnford/fix/onboarding
tdurnford May 17, 2021
ee72431
Merge branch 'main' into durnford/fix/onboarding
hatpick May 21, 2021
e188e79
Merge branch 'main' into durnford/fix/onboarding
tdurnford May 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion Composer/packages/client/src/Onboarding/content.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ export const getTeachingBubble = (id: string | undefined): TeachingBubble => {
},
};

case 'projectSettings':
case 'publish':
return {
content: formatMessage('Publish your bot to Azure and manage published bots here.'),
headline: formatMessage('Configure and publish'),
Expand Down
4 changes: 3 additions & 1 deletion Composer/packages/client/src/components/NavItem.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,9 @@ export const NavItem: React.FC<INavItemProps> = (props) => {

const active = (pathname.startsWith(to) || match?.test(pathname)) ?? false;

const addRef = useCallback((ref) => onboardingAddCoachMarkRef({ [`nav${labelName.replace(' ', '')}`]: ref }), []);
const addRef = useCallback((ref) => onboardingAddCoachMarkRef({ [`nav${labelName.replace(' ', '')}`]: ref }), [
labelName,
]);

const getIcon = (iconName: string) => {
let navIcon;
Expand Down