fix: add learn more link for export as skill #7939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanlong9278
requested review from
a-b-r-o-w-n,
benbrown,
beyackle,
boydc2014,
cwhitten,
GeoffCoxMSFT,
hatpick,
pavolum,
srinaath,
tdurnford and
tonyanziano
as code owners
tdurnford
reviewed
May 27, 2021
Composer/packages/client/src/pages/design/exportSkillModal/constants.tsx
Show resolved
Hide resolved
tdurnford
reviewed
May 27, 2021
Composer/packages/client/src/pages/design/exportSkillModal/constants.tsx
Outdated
Show resolved
Hide resolved
hatpick
suggested changes
May 27, 2021
Composer/packages/client/src/pages/design/exportSkillModal/constants.tsx
Outdated
Show resolved
Hide resolved
Composer/packages/client/src/pages/design/exportSkillModal/constants.tsx
Outdated
Show resolved
Hide resolved
|
why is there a blank space below the buttons in this dialog? |
Sorry, I dont get u. |
tdurnford
requested changes
Jun 3, 2021
Composer/packages/client/src/pages/design/exportSkillModal/constants.tsx
Outdated
Show resolved
Hide resolved
tdurnford
previously approved these changes
Jun 3, 2021
In the screen recording you have attached, there is a gap between the dialog buttons and the bottom of the dialog, why is that? your dialog
normal dialog
|
|
@alanlong9278 what's the status of work on this PR, did you see my question above with screenshots? |
benbrown
force-pushed
the
julong/add-link
branch
from
98f80e2
to
53e2baa
Compare
Sorry, I am on vacations these days. I will fix it today @hatpick |
|
@hatpick could you please take another look at this PR? |
hatpick
approved these changes
Jun 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix: add learn more link for select trigger, select dialog & allow callers pages in
export as skillexperience.Task Item
closes #7851
Screenshots