fix: refactor azure provisioning extension #7993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeoffCoxMSFT
reviewed
Jun 2, 2021
GeoffCoxMSFT
reviewed
Jun 2, 2021
GeoffCoxMSFT
reviewed
Jun 2, 2021
GeoffCoxMSFT
reviewed
Jun 2, 2021
extensions/azurePublish-new/src/components/AzureProvisionDialog.tsx
Outdated
Show resolved
Hide resolved
GeoffCoxMSFT
reviewed
Jun 2, 2021
extensions/azurePublish-new/src/components/AzureProvisionDialog.tsx
Outdated
Show resolved
Hide resolved
GeoffCoxMSFT
reviewed
Jun 2, 2021
extensions/azurePublish-new/src/components/ChooseProvisionAction.tsx
Outdated
Show resolved
Hide resolved
GeoffCoxMSFT
reviewed
Jun 2, 2021
extensions/azurePublish-new/src/components/ChooseProvisionAction.tsx
Outdated
Show resolved
Hide resolved
GeoffCoxMSFT
reviewed
Jun 2, 2021
extensions/azurePublish-new/src/components/ChooseProvisionAction.tsx
Outdated
Show resolved
Hide resolved
hatpick
reviewed
Jun 2, 2021
extensions/azurePublish-new/src/components/ChooseProvisionAction.tsx
Outdated
Show resolved
Hide resolved
extensions/azurePublish-new/src/components/ChooseProvisionAction.tsx
Outdated
Show resolved
Hide resolved
...nsions/azurePublish-new/src/components/provisioningWizards/steps/CreateActionContentStep.tsx
Outdated
Show resolved
Hide resolved
...nsions/azurePublish-new/src/components/provisioningWizards/steps/CreateActionContentStep.tsx
Outdated
Show resolved
Hide resolved
...nsions/azurePublish-new/src/components/provisioningWizards/steps/ImportActionContentStep.tsx
Outdated
Show resolved
Hide resolved
...ions/azurePublish-new/src/components/provisioningWizards/steps/ResourceConfigurationStep.tsx
Outdated
Show resolved
Hide resolved
...ions/azurePublish-new/src/components/provisioningWizards/steps/ResourceConfigurationStep.tsx
Outdated
Show resolved
Hide resolved
GeoffCoxMSFT
reviewed
Jun 4, 2021
GeoffCoxMSFT
reviewed
Jun 4, 2021
GeoffCoxMSFT
reviewed
Jun 7, 2021
VamsiModem
requested review from
a-b-r-o-w-n,
benbrown,
beyackle,
boydc2014 and
cwhitten
as code owners
GeoffCoxMSFT
reviewed
Jun 8, 2021
extensions/azurePublishNew/src/components/AzureProvisionWizard.tsx
Outdated
Show resolved
Hide resolved
hatpick
suggested changes
Jun 8, 2021
extensions/azurePublishNew/src/components/AzureProvisionWizard.tsx
Outdated
Show resolved
Hide resolved
extensions/azurePublishNew/src/components/AzureProvisionWizard.tsx
Outdated
Show resolved
Hide resolved
extensions/azurePublishNew/src/recoilModel/atoms/resourceConfigurationState.ts
Outdated
Show resolved
Hide resolved
extensions/azurePublishNew/src/recoilModel/atoms/resourceConfigurationState.ts
Outdated
Show resolved
Hide resolved
extensions/azurePublishNew/src/recoilModel/selectors/tenants.ts
Outdated
Show resolved
Hide resolved
hatpick
reviewed
Jun 10, 2021
extensions/azurePublishNew/src/components/ChooseProvisionAction.tsx
Outdated
Show resolved
Hide resolved
…otFramework-Composer into vmodem/azure-publish
hatpick
previously approved these changes
Jun 11, 2021
GeoffCoxMSFT
approved these changes
Jun 11, 2021
a-b-r-o-w-n
approved these changes
Jun 11, 2021
a-b-r-o-w-n
pushed a commit
that referenced
this pull request
Jun 11, 2021
* initial commit for new provisioning extension * Renamed extension, added auto complete component * Deleted all the old files * Modified Wizard to use render props approach, added signout support and footer with user persona * Removed styled component deps * Cleaned up props and added new components * Moved constants to a new file * Made changes per PR comments * cleaned up Handoff wizard code * Removed unncessary formatting * Changes as per PR comments * Added recoil dispatchers * Removed unnecessary code * Added useDispatcher hook * Removed unwanted deps * Removed barrel files * Moved urls to the top in each file * Added Text tag for all the instructions * Changed parameter name * Added Code owners for azurePublishNew
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added a new extension for azure publish
Task Item
fixes #7632
fixes #7631