New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: introduce tests for ManageService component #8039
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benbrown
requested review from
a-b-r-o-w-n,
beyackle,
boydc2014,
cwhitten,
GeoffCoxMSFT,
hatpick,
pavolum,
srinaath,
tdurnford and
tonyanziano
as code owners
June 9, 2021 21:49
pavolum
reviewed
Jun 10, 2021
Composer/packages/client/src/components/ManageService/__tests__/ManageService.test.tsx
Outdated
Show resolved
Hide resolved
Composer/packages/client/src/components/ManageService/__tests__/ManageService.test.tsx
Outdated
Show resolved
Hide resolved
…oser into benbrown/manageservicetests
benbrown
force-pushed
the
benbrown/manageservicetests
branch
from
June 11, 2021 18:59
f5607f7
to
0275e77
Compare
hatpick
reviewed
Jun 14, 2021
Composer/packages/client/src/components/ManageLuis/__tests__/ManageLuis.test.tsx
Outdated
Show resolved
Hide resolved
Component tests are generally in |
…o benbrown/manageservicetests
…o benbrown/manageservicetests
hatpick
approved these changes
Jun 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a suite of unit test cases for the base ManageService component (which is in turn used to create the ManageLuis, ManageQNA and ManageSpeech components)
Tests so far:
This involved creating simple mocks for a variety of Azure ARM APIs.
Still to come:
Task Item
Fixes #7902