fix: Provisioning hand-off should use resource name not resource group name #8085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeoffCoxMSFT
requested review from
a-b-r-o-w-n,
boydc2014 and
cwhitten
as code owners
|
@benbrown Do I need to update the https://github.com/microsoft/BotFramework-Composer/blob/main/Provisioning/provisionScripts.zip manually? |
hatpick
approved these changes
Jun 15, 2021
beyackle
approved these changes
Jun 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Customer reported that provisioning hand-off script defaults many resources to the resource group name. Updated the script to pass the resource name to the ARM template. Updated the arm template to default several values to the name parameter rather than defaulting to the resource group name.
Task Item
fixes #7966
Screenshots
A set of resources provisioned by Composer
A set of resources provisioned by the hand-off script before the fix
A set of resources provisioned by the hand-off script after the fix
