Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: connect to local manifest & copy manifest.json and lu files to current bot #8146

Merged
merged 59 commits into from Jul 2, 2021
Merged

feat: connect to local manifest & copy manifest.json and lu files to current bot #8146

merged 59 commits into from Jul 2, 2021

Conversation

alanlong9278
Copy link
Contributor

@alanlong9278 alanlong9278 commented Jun 21, 2021 •
edited by VanyLaw

Description

  • connect to local manifest @VanyLaw

  • copy manifest.json and lu files to current bot

  1. from http url
    files

  2. from local zip
    skillZip

Task Item

close #7864
close #7852

Screenshots

@cypress
Copy link

cypress bot commented Jun 21, 2021 •
edited


Test summary

16 • 0 • 1 • 0 • Flakiness 0

Run details
Project Composer
Status Passed
Commit 07c871f
Started Jul 2, 2021 7:04 AM
Ended Jul 2, 2021 7:10 AM
Duration 05:52 💡
OS Linux Ubuntu - 20.04
Browser Electron 89

View run in Cypress Dashboard ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@cwhitten
Copy link
Member

@alanlong9278 does this support the format that PVA will export? It is a .zip format with both the manifest and the language data inside of it.

cc @luhan2017 @gabog

@alanlong9278
Copy link
Contributor Author

@alanlong9278 does this support the format that PVA will export? It is a .zip format with both the manifest and the language data inside of it.

cc @luhan2017 @gabog

@cwhitten We will support zip format, I changed this pr into draft

@alanlong9278 alanlong9278 marked this pull request as draft June 22, 2021 08:36
@VanyLaw VanyLaw mentioned this pull request Jun 29, 2021
Closed
VanyLaw and others added 2 commits June 29, 2021 15:18
@VanyLaw
add test
abfaaad
@luhan2017 @EricDahlvang
Update Composer/packages/client/src/components/AddRemoteSkillModal/Cr…
a0f521a 
…eateSkillModal.tsx

Co-authored-by: Eric Dahlvang <erdahlva@microsoft.com>
@luhan2017
Copy link
Contributor

@alanlong9278 can we add the telemetry data to tell if the manifest is http-based or load from zip content?

@alanlong9278
Copy link
Contributor Author

@alanlong9278 can we add the telemetry data to tell if the manifest is http-based or load from zip content?

Sure

@luhan2017 luhan2017 merged commit 06e1b66 into main Jul 2, 2021
@luhan2017 luhan2017 deleted the skill-manifests branch July 2, 2021 07:15
@luhan2017 luhan2017 mentioned this pull request Jul 6, 2021
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EricDahlvang EricDahlvang EricDahlvang left review comments

@luhan2017 luhan2017 luhan2017 approved these changes

@lei9444 lei9444 lei9444 left review comments

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n

@benbrown benbrown Awaiting requested review from benbrown

@beyackle beyackle Awaiting requested review from beyackle

@boydc2014 boydc2014 Awaiting requested review from boydc2014

@cwhitten cwhitten Awaiting requested review from cwhitten

@GeoffCoxMSFT GeoffCoxMSFT Awaiting requested review from GeoffCoxMSFT

@hatpick hatpick Awaiting requested review from hatpick

@pavolum pavolum Awaiting requested review from pavolum

@srinaath srinaath Awaiting requested review from srinaath

@tdurnford tdurnford Awaiting requested review from tdurnford

@tonyanziano tonyanziano Awaiting requested review from tonyanziano

Assignees

@EricDahlvang EricDahlvang

@luhan2017 luhan2017

@lei9444 lei9444

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Load skill manifests from any location Add skill via manifest fails to load remote LU
7 participants
@alanlong9278 @cwhitten @luhan2017 @coveralls @EricDahlvang @lei9444 @VanyLaw