Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: electron build failed to copy runtime folder #8148

Merged
merged 1 commit into from Jun 21, 2021
Merged

fix: electron build failed to copy runtime folder #8148

merged 1 commit into from Jun 21, 2021

Conversation

lei9444
Copy link
Contributor

@lei9444 lei9444 commented Jun 21, 2021 •
edited

Description

image

root cause
runtime folder has been removed in #7870. But the electron build still copy the runtime folder and will throw error

Task Item

#minor

Screenshots

@cypress
Copy link

cypress bot commented Jun 21, 2021


Test summary

16 • 0 • 1 • 0 • Flakiness 0

Run details
Project Composer
Status Passed
Commit bb17912
Started Jun 21, 2021 2:11 PM
Ended Jun 21, 2021 2:19 PM
Duration 07:25 💡
OS Linux Ubuntu - 20.04
Browser Electron 89

View run in Cypress Dashboard ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@coveralls
Copy link

Coverage Status

Coverage remained the same at 54.86% when pulling bb17912 on lei9444:fixbuild into e545ab8 on microsoft:main.

@a-b-r-o-w-n a-b-r-o-w-n merged commit 05de11a into microsoft:main Jun 21, 2021
@a-b-r-o-w-n a-b-r-o-w-n deleted the fixbuild branch June 21, 2021 15:47
@benbrown
Copy link
Contributor

I'm sorry about this! @hatpick reminded us to check this file but I forgot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a-b-r-o-w-n a-b-r-o-w-n a-b-r-o-w-n approved these changes

@benbrown benbrown Awaiting requested review from benbrown

@beyackle beyackle Awaiting requested review from beyackle

@boydc2014 boydc2014 Awaiting requested review from boydc2014

@cwhitten cwhitten Awaiting requested review from cwhitten

@GeoffCoxMSFT GeoffCoxMSFT Awaiting requested review from GeoffCoxMSFT

@hatpick hatpick Awaiting requested review from hatpick

@pavolum pavolum Awaiting requested review from pavolum

@srinaath srinaath Awaiting requested review from srinaath

@tdurnford tdurnford Awaiting requested review from tdurnford

@tonyanziano tonyanziano Awaiting requested review from tonyanziano

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lei9444 @coveralls @benbrown @a-b-r-o-w-n