feat: Add "Watch" tab to the debug panel #8151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonyanziano
changed the title
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
hatpick
reviewed
Jun 21, 2021
Composer/packages/client/src/pages/design/DebugPanel/TabExtensions/WatchTab/WatchTabContent.tsx
Outdated
Show resolved
Hide resolved
Composer/packages/client/src/pages/design/DebugPanel/TabExtensions/WatchTab/WatchTabContent.tsx
Outdated
Show resolved
Hide resolved
Composer/packages/client/src/pages/design/DebugPanel/TabExtensions/WatchTab/WatchTabContent.tsx
Show resolved
Hide resolved
Composer/packages/client/src/pages/design/DebugPanel/TabExtensions/WatchTab/WatchTabContent.tsx
Outdated
Show resolved
Hide resolved
Composer/packages/client/src/pages/design/DebugPanel/TabExtensions/WatchTab/WatchTabContent.tsx
Outdated
Show resolved
Hide resolved
...er/packages/client/src/pages/design/DebugPanel/WatchVariableSelector/WatchVariablePicker.tsx
Outdated
Show resolved
Hide resolved
...er/packages/client/src/pages/design/DebugPanel/WatchVariableSelector/WatchVariablePicker.tsx
Outdated
Show resolved
Hide resolved
...er/packages/client/src/pages/design/DebugPanel/WatchVariableSelector/WatchVariablePicker.tsx
Outdated
Show resolved
Hide resolved
...er/packages/client/src/pages/design/DebugPanel/WatchVariableSelector/WatchVariablePicker.tsx
Outdated
Show resolved
Hide resolved
.../pages/design/DebugPanel/WatchVariableSelector/utils/components/PickerContextualMenuItem.tsx
Outdated
Show resolved
Hide resolved
srinaath
reviewed
Jun 22, 2021
Composer/packages/client/src/pages/design/DebugPanel/TabExtensions/WatchTab/WatchTabContent.tsx
Outdated
Show resolved
Hide resolved
srinaath
reviewed
Jun 22, 2021
Composer/packages/client/src/recoilModel/dispatchers/webchat.ts
Outdated
Show resolved
Hide resolved
srinaath
reviewed
Jun 22, 2021
Composer/packages/client/src/pages/design/DebugPanel/TabExtensions/WatchTab/WatchTabContent.tsx
Outdated
Show resolved
Hide resolved
…oser into toanzian/watch-tab
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
…Framework-Composer into toanzian/watch-tab
…oser into toanzian/watch-tab
|
I have addressed all of Soroush's comments and also adjusted some styles that looked off from the specs. Here is the updated tab with new "not available" message and placeholder text:
@srinaath I still can't repro bug 4 as seen in the screenshot, but I can confirm bugs 1-3 and am working to fix these. |
|
@tonyanziano Ignore bug 4. I just realized a bot logic error which was converting the boolean to string to on the variable. So basically it was casting to "true". So we are good on that front. |
srinaath
reviewed
Jun 28, 2021
...r/packages/client/src/pages/design/DebugPanel/TabExtensions/WatchTab/WatchTabObjectValue.tsx
Outdated
Show resolved
Hide resolved
srinaath
reviewed
Jun 28, 2021
Composer/packages/client/src/pages/design/DebugPanel/TabExtensions/WatchTab/WatchTabContent.tsx
Show resolved
Hide resolved
|
All of the bugs / issues have been fixed and styles updated to appear more like the updated designs:
|
|
@tonyanziano minor thing, can the table be slightly narrower so there is 16px of space on either side? where the pink lines are: |
…oser into toanzian/watch-tab
|
@mewa1024 Fixed spacing:
|
hatpick
approved these changes
Jun 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the Watch tab to the debugging panel.
The Watch tab allows users to observe arbitrary variables stored in the bot's different memory scopes while interacting with the bot.
Task Item
Fixes #7978
Screenshots
Bot not yet started
Talking to bot
Validation