fix: Added in-code default bot project file to use for old bots #8181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonyanziano
requested review from
a-b-r-o-w-n,
benbrown,
beyackle,
boydc2014,
cwhitten,
GeoffCoxMSFT,
hatpick,
pavolum,
srinaath and
tdurnford
as code owners
tonyanziano
changed the title
benbrown
approved these changes
Jun 23, 2021
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In a recent change #7870, all the existing bot templates that existed in
/extensions/samples/assets/projectswere removed. There was a piece of code inside ofBotProject.init()that would use the.botprojfile of the first bot template in that directory as a skeleton to be filled out for old bots that needed to create a project file.Since there are no longer any bot templates in that directory, this piece of code always returns
undefinedand no.botprojfile is created for old bots. This was causing bots imported from PVA to throw an error when being opened because of a missing project fileThis PR takes the old
.botprojskeleton that was present in the EchoBot sample and puts it into the code to be referenced by old bots.#minor