New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement provisioning for app registration, web app, service plan #8201
Conversation
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
@@ -9,6 +9,7 @@ export type ResourceProvisionService = { | |||
getDependencies: () => string[]; | |||
getRecommendationForProject: (project: IBotProject) => 'required' | 'optional' | 'notAllowed'; | |||
provision: ProvisionMethod; | |||
canPollStatus: boolean; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand this boolean. I was thinking that the provision method would take the status update callback (which is what I am going to try and define next). Can you tell me more about this boolean?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some of the SDK create/update methods return a special LROPoller
object with methods for interacting with long running Azure operations (response 202). I thought it would be cool to use that.
But some (such as App Reg, Bot Channel Registration, and App Insights) won't have that - those will just take the onUploadProgress/onDownloadProgress callbacks.
Description
implement provisioning for app registration, web app, service plan
Task Item
refs #7629