Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement provisioning for app registration, web app, service plan #8201

Merged
merged 9 commits into from Jun 29, 2021

Conversation

natalgar
Copy link
Contributor

Description

implement provisioning for app registration, web app, service plan

Task Item

refs #7629

@cypress
Copy link

cypress bot commented Jun 28, 2021



Test summary

16 0 1 0Flakiness 0


Run details

Project Composer
Status Passed
Commit 36e6ae1
Started Jun 29, 2021 7:07 PM
Ended Jun 29, 2021 7:13 PM
Duration 05:50 💡
OS Linux Ubuntu - 20.04
Browser Electron 89

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@coveralls
Copy link

coveralls commented Jun 28, 2021

Coverage Status

Coverage remained the same at 54.656% when pulling 36e6ae1 on natalgar/7629-provision-config into 2088670 on main.

@natalgar natalgar changed the title Natalgar/7629 provision config feat: implement provisioning for app registration, web app, service plan Jun 28, 2021
@@ -9,6 +9,7 @@ export type ResourceProvisionService = {
getDependencies: () => string[];
getRecommendationForProject: (project: IBotProject) => 'required' | 'optional' | 'notAllowed';
provision: ProvisionMethod;
canPollStatus: boolean;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand this boolean. I was thinking that the provision method would take the status update callback (which is what I am going to try and define next). Can you tell me more about this boolean?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of the SDK create/update methods return a special LROPoller object with methods for interacting with long running Azure operations (response 202). I thought it would be cool to use that.
But some (such as App Reg, Bot Channel Registration, and App Insights) won't have that - those will just take the onUploadProgress/onDownloadProgress callbacks.

@natalgar natalgar marked this pull request as ready for review June 29, 2021 18:48
@natalgar natalgar merged commit a4770e5 into main Jun 29, 2021
@natalgar natalgar deleted the natalgar/7629-provision-config branch June 29, 2021 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants