New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: revise text in Azure Bot creation dialog #8232
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beyackle
requested review from
a-b-r-o-w-n,
benbrown,
boydc2014,
cwhitten,
GeoffCoxMSFT,
hatpick,
pavolum,
srinaath,
tdurnford and
tonyanziano
as code owners
June 30, 2021 21:33
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
tdurnford
requested changes
Jul 1, 2021
Composer/packages/client/src/components/CreationFlow/AzureBotDialog.tsx
Outdated
Show resolved
Hide resolved
Composer/packages/client/src/components/CreationFlow/AzureBotDialog.tsx
Outdated
Show resolved
Hide resolved
Composer/packages/client/src/components/CreationFlow/AzureBotDialog.tsx
Outdated
Show resolved
Hide resolved
tdurnford
approved these changes
Jul 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This turned out to be more than a simple copy change; adding the Learn More link meant I had to restructure the dialog a little, and I refactored it out into its own file to be a little cleaner and easier to modify.
Task Item
closes #8166
Screenshots