Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Adaptive card rendering issue in Webchat & Rerender on appId change #8238

Merged
merged 3 commits into from Jul 1, 2021

Conversation

srinaath
Copy link
Contributor

@srinaath srinaath commented Jul 1, 2021

Description

  1. A bad import from webchat-component caused the rendering of adaptive cards to break. Fixed the import to be from webchat.
  2. The conversation is memoized for until a new bot is opened. This makes the webchat hold on to stale MsAppId and MsPassword when the secrets are updated. Adding secret as a dependancy as well to change conversationID along with secret.
    @boydc2014 @luhan2017 Could you give this branch a go if this fixes it?

Screen Shot 2021-06-30 at 5 37 58 PM

Task Item

Fixes #8226

Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
@cypress
Copy link

cypress bot commented Jul 1, 2021



Test summary

16 0 1 0Flakiness 0


Run details

Project Composer
Status Passed
Commit 97ec1b6
Started Jul 1, 2021 1:59 AM
Ended Jul 1, 2021 2:08 AM
Duration 08:33 💡
OS Linux Ubuntu - 20.04
Browser Electron 89

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
@srinaath srinaath changed the title fix: Adaptive card rendering issue in Webchat fix: Adaptive card rendering issue in Webchat & Rerender on appId change Jul 1, 2021
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
@coveralls
Copy link

coveralls commented Jul 1, 2021

Coverage Status

Coverage decreased (-0.001%) to 55.433% when pulling 97ec1b6 on fix/thumbnailcards into 7d3433a on main.

@hatpick hatpick merged commit 0820298 into main Jul 1, 2021
@hatpick hatpick deleted the fix/thumbnailcards branch July 1, 2021 02:43
@boydc2014
Copy link
Contributor

Confirmed, this PR fixed the appid\password not refreshing issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WebChat doesn't work if I update the MicrosoftAppId and MicrosoftPassword and restart my bot
5 participants