New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Ensure manifest.json not found in zip displays error #8261
Conversation
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
'https://schemas.botframework.com/schemas/skills/v2.2/skill-manifest.json', | ||
]; | ||
return urls.includes(JSON.parse(content).$schema); | ||
const versions = ['/v2.0/', '/v2.1/', '/v2.2/']; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any reason we should worry about a $schema
field matching these shorter version strings but being something other than a longer URL (like the ones that used to be here)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While the entire path is more correct, this seems less restrictive. I had a mistake in a manifest schema path, while the rest of the manifest was correct. I do not feel strongly about this though. If you object, we can skip this change.
Maybe we should be checking the $version, instead of the #schema path. Considering, our previous .schema had no version in the $id path: https://schemas.botframework.com/schemas/skills/v2.0/skill-manifest.json
"$id": "https://schemas.botframework.com/schemas/skills/skill-manifest.json",
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@beyackle adjusted to endsWith '{v}/skill-manifest.json' and remove v2.0, considering the above comment
Description
Task Item
fixes #8260
closes #8260
Screenshots