fix: luisresource missing from import #8288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 7, 2021 15:29
natalgar
requested review from
benbrown,
GeoffCoxMSFT,
hatpick,
tonyanziano and
VamsiModem
as code owners
natalgar
commented
Jul 7, 2021
| @@ -155,6 +155,7 @@ const schema: JSONSchema7 = { | |||
| subscriptionId: '<id of your subscription>', | |||
| region: '<region of your resource group>', | |||
| appServiceOperatingSystem: 'windows', | |||
| luisResource: '<name of your luis resource>', | |||
There was a problem hiding this comment.
I put it up here with the other attributes of the same level. But if folks are used to seeing at at the bottom, below MicrosoftAppId, MicrosoftAppPassword I can move it there.
There was a problem hiding this comment.
Yes having it at the top makes sense.
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
hatpick
approved these changes
Jul 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
add
luisResourceto the default schema for Azure PublishingTask Item
fixes #8244