Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add ability to resolve remote or relative schema $refs #8293

Merged
merged 5 commits into from Jul 8, 2021
Merged

feat: add ability to resolve remote or relative schema $refs #8293

merged 5 commits into from Jul 8, 2021

Conversation

a-b-r-o-w-n
Copy link
Contributor

Description

Adds ability to resolve $refs in external schemas (either remote or relative files).

Task Item

closes #8271

beyackle
beyackle approved these changes Jul 8, 2021
View reviewed changes
Copy link
Contributor

@beyackle beyackle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small "fix it if you want to" thing, but this looks good otherwise, so I'll leave it to you if you want to do anything about it.

Composer/packages/ui-plugins/schema-editor/src/Fields/ValueRefField.tsx Outdated Show resolved Hide resolved
@cypress
Copy link

cypress bot commented Jul 8, 2021 •
edited


Test summary

16 • 0 • 1 • 0 • Flakiness 1

Run details
Project Composer
Status Passed
Commit 389c8cb
Started Jul 8, 2021 6:00 PM
Ended Jul 8, 2021 6:07 PM
Duration 06:47 💡
OS Linux Ubuntu - 20.04
Browser Electron 89

View run in Cypress Dashboard ➡️

Flakiness

cypress/integration/DesignPage.spec.ts 1 Flakiness
1 breadcrumb > can create different kinds of triggers

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@coveralls
Copy link

coveralls commented Jul 8, 2021 •
edited

Coverage Status

Coverage increased (+0.02%) to 56.276% when pulling 389c8cb on abrown/resolve-refs into db22986 on main.

@a-b-r-o-w-n a-b-r-o-w-n merged commit 86f05c3 into main Jul 8, 2021
@a-b-r-o-w-n a-b-r-o-w-n deleted the abrown/resolve-refs branch July 8, 2021 19:50
@a-b-r-o-w-n a-b-r-o-w-n mentioned this pull request Jul 14, 2021
Closed
a-b-r-o-w-n added a commit that referenced this pull request Jul 21, 2021
@a-b-r-o-w-n
revert "feat: add ability to resolve remote or relative schema $refs (#…
141dd34 
…8293)"

This reverts commit 86f05c3.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beyackle beyackle beyackle approved these changes

@benbrown benbrown Awaiting requested review from benbrown

@boydc2014 boydc2014 Awaiting requested review from boydc2014

@cwhitten cwhitten Awaiting requested review from cwhitten

@GeoffCoxMSFT GeoffCoxMSFT Awaiting requested review from GeoffCoxMSFT

@hatpick hatpick Awaiting requested review from hatpick

@natalgar natalgar Awaiting requested review from natalgar

@pavolum pavolum Awaiting requested review from pavolum

@srinaath srinaath Awaiting requested review from srinaath

@tdurnford tdurnford Awaiting requested review from tdurnford

@tonyanziano tonyanziano Awaiting requested review from tonyanziano

@VamsiModem VamsiModem Awaiting requested review from VamsiModem

Assignees

@beyackle beyackle

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[pva] add ability to resolve local and remote schemas
3 participants
@a-b-r-o-w-n @coveralls @beyackle