Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add support of suggesting all entities in multiple import levels #8306

Merged
merged 2 commits into from Jul 9, 2021

Conversation

cosmicshuai
Copy link
Contributor

closes #8295
For higher level imports, the LU editor now is able to suggest all entities defined.
For example, in form dialog:
Screen Shot 2021-07-09 at 3 15 50 PM

Another example:
Empty.en-us.lu imports test.en-us.lu, test.en-us.lu imports compact2.en-us.lu and level2.en-us.lu, level2.en-us.lu imports level3.en-us.lu. Once user editing in Empty.en-us.lu, the editor can suggest all entities defined in all imported files.
image

@cosmicshuai cosmicshuai changed the title Fix: Add support of suggesting all entities in multiple import levels fix: Add support of suggesting all entities in multiple import levels Jul 9, 2021
@cypress
Copy link

cypress bot commented Jul 9, 2021



Test summary

16 0 1 0Flakiness 1


Run details

Project Composer
Status Passed
Commit 9dbce58
Started Jul 9, 2021 5:34 PM
Ended Jul 9, 2021 5:43 PM
Duration 08:48 💡
OS Linux Ubuntu - 20.04
Browser Electron 89

View run in Cypress Dashboard ➡️


Flakiness

cypress/integration/DesignPage.spec.ts Flakiness
1 breadcrumb > can create different kinds of triggers

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

Copy link
Contributor

@chrimc62 chrimc62 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@coveralls
Copy link

Coverage Status

Coverage remained the same at 56.423% when pulling 9dbce58 on shuwan/fixLUDeepImport into 05b856d on main.

@hatpick hatpick merged commit 9e2b9d7 into main Jul 9, 2021
@hatpick hatpick deleted the shuwan/fixLUDeepImport branch July 9, 2021 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LU intellisense only works for a single level of imports
4 participants