New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fixed Web Chat tab switching behavior #8391
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonyanziano
requested review from
a-b-r-o-w-n,
benbrown,
beyackle,
boydc2014,
cwhitten,
GeoffCoxMSFT,
hatpick,
natalgar,
pavolum,
srinaath,
tdurnford and
VamsiModem
as code owners
July 13, 2021 22:25
tonyanziano
changed the title
Fixed Web Chat tab switching behavior
fix: Fixed Web Chat tab switching behavior
Jul 13, 2021
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
hatpick
reviewed
Jul 13, 2021
Composer/packages/client/src/components/WebChat/hooks/useTranscriptFocusListener.ts
Show resolved
Hide resolved
…oft/BotFramework-Composer into toanzian/watch-tab-switch
hatpick
approved these changes
Jul 14, 2021
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Clicking / focusing a message in the Web Chat panel, currently opens the debug panel if it is closed, and switches from whatever tab you are on to the Web Chat tab.
This PR stops the message selection from switching the active tab, unless it is your first time opening the debug panel.
Task Item
fixes #8365 (P0)
Screenshots