Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed Web Chat tab switching behavior #8391

Merged
merged 8 commits into from Jul 14, 2021
Merged

Conversation

tonyanziano
Copy link
Contributor

@tonyanziano tonyanziano commented Jul 13, 2021

Description

Clicking / focusing a message in the Web Chat panel, currently opens the debug panel if it is closed, and switches from whatever tab you are on to the Web Chat tab.

This PR stops the message selection from switching the active tab, unless it is your first time opening the debug panel.

Task Item

fixes #8365 (P0)

Screenshots

WatchTabP0Fix

@tonyanziano tonyanziano changed the title Fixed Web Chat tab switching behavior fix: Fixed Web Chat tab switching behavior Jul 13, 2021
@cypress
Copy link

cypress bot commented Jul 13, 2021



Test summary

16 0 1 0Flakiness 0


Run details

Project Composer
Status Passed
Commit 5140121
Started Jul 14, 2021 6:12 PM
Ended Jul 14, 2021 6:19 PM
Duration 06:27 💡
OS Linux Ubuntu - 20.04
Browser Electron 89

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@coveralls
Copy link

Coverage Status

Coverage increased (+0.002%) to 55.767% when pulling a4c7462 on toanzian/watch-tab-switch into 72c4e3a on main.

@tonyanziano tonyanziano merged commit fe589c5 into main Jul 14, 2021
@tonyanziano tonyanziano deleted the toanzian/watch-tab-switch branch July 14, 2021 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Web Chat log opens when you click on a card, making it difficult to use Watch
3 participants