Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove version in manifest json file name #8414

Merged
merged 7 commits into from Jul 20, 2021

Conversation

alanlong9278
Copy link
Contributor

Description

use version to generate manifest json file name
version

Task Item

closes #8352

Screenshots

@cypress
Copy link

cypress bot commented Jul 15, 2021



Test summary

16 0 1 0Flakiness 1


Run details

Project Composer
Status Passed
Commit 31436a8
Started Jul 20, 2021 7:55 AM
Ended Jul 20, 2021 8:00 AM
Duration 05:22 💡
OS Linux Ubuntu - 20.04
Browser Electron 89

View run in Cypress Dashboard ➡️


Flakiness

cypress/integration/DesignPage.spec.ts Flakiness
1 breadcrumb > can create different kinds of triggers

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 55.817% when pulling 2d37171 on julong/manifestUrlName into 466c8b2 on main.

@luhan2017
Copy link
Contributor

luhan2017 commented Jul 16, 2021

Let's hold on this change, this will generate a list of manifest files locally for each version, it is tricky, if we want to show all to the user, we need to make the version a number sortable, and this may cause user experiences change.

I have another proposal in the issue link. I think we can simplify this by

  • disable the manfiest selection and always use schema 2.2 to generate manfiest file.
  • just use "manifest.json" as the name, and always keep one manifest locally. (all the dialog assets doesn't have a version concept, it is not valid to only keep the manifest versions)

@luhan2017 luhan2017 changed the title chore: use version to generate manifest json file name chore: remove version in manifest json file name Jul 20, 2021
@luhan2017 luhan2017 merged commit 339a82b into main Jul 20, 2021
@luhan2017 luhan2017 deleted the julong/manifestUrlName branch July 20, 2021 08:27
alanlong9278 added a commit that referenced this pull request Jul 20, 2021
…soft/BotFramework-Composer into julong/validata-skill-name

* 'julong/validata-skill-name' of https://github.com/microsoft/BotFramework-Composer:
  chore: remove version in manifest json file name (#8414)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The version of the bot property should be used in the manifest path, not the skill manifest version
3 participants