Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Problems pane reset #8426

Merged
merged 3 commits into from Jul 19, 2021
Merged

fix: Problems pane reset #8426

merged 3 commits into from Jul 19, 2021

Conversation

srinaath
Copy link
Contributor

Description

This PR

  1. Resets the show warning and show error states in the DebuPane to true when swapping bots
  2. When a bot project is opened it defaults to "All" option to show errors and warnings across bots. When a new skill is added to the solution it sets it again to "All" option.

Task Item

Fixes #8345

Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
@cypress
Copy link

cypress bot commented Jul 18, 2021



Test summary

16 0 1 0Flakiness 0


Run details

Project Composer
Status Passed
Commit 5fa63e7
Started Jul 19, 2021 3:02 AM
Ended Jul 19, 2021 3:09 AM
Duration 07:21 💡
OS Linux Ubuntu - 20.04
Browser Electron 89

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@coveralls
Copy link

coveralls commented Jul 18, 2021

Coverage Status

Coverage decreased (-0.01%) to 55.834% when pulling 5fa63e7 on fix/problems-pane into a72671d on main.

Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
@srinaath srinaath merged commit 26b6d19 into main Jul 19, 2021
@srinaath srinaath deleted the fix/problems-pane branch July 19, 2021 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problems pane defaults settings should be to show both errors and warning and all bots
4 participants