Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump botframework-streaming to 4.11.0 #323

Merged
merged 2 commits into from Feb 10, 2021
Merged

bump botframework-streaming to 4.11.0 #323

merged 2 commits into from Feb 10, 2021

Conversation

stevengum
Copy link
Member

@stevengum stevengum commented Nov 24, 2020

And add .vscode to .gitignore.

Testing:

  1. Followed React Native's Setting up the development environment via the Expo CLI Quickstart route.
  2. yarn add botframework-directlinejs to RN project (downloaded 0.14.0)
  3. yarn add @expo/webpack-config to RN project (has dependency on Webpack 4)
  4. Create webpack.config.js, modify file to not use node polyfills
  5. Run yarn web, observed that it failed to build due not resolving 'stream'
  6. Used yarn link to link RN project with local clone of this PR's branch stgum/bf-s/4.11
  7. Run yarn web again, success.
webpack.config.js
const createExpoWebpackConfigAsync = require('@expo/webpack-config');

// Expo CLI will await this method so you can optionally return a promise.
module.exports = async function(env, argv) {
  const config = await createExpoWebpackConfigAsync(env, argv);
  // If you want to add a new alias to the config.
  config.resolve.alias['moduleA'] = 'moduleB';

  // Maybe you want to turn off compression in dev mode.
  if (config.mode === 'development') {
    config.devServer.compress = false;
  }

  config.node = false;

  // Or prevent minimizing the bundle when you build.
  if (config.mode === 'production') {
    config.optimization.minimize = false;
  }

  // Finally return the new config for the CLI to use.
  return config;
};

* add .vscode to .gitignore
@stevengum
Copy link
Member Author

Successful build (#473) for 28bc778 via Travis

Copy link
Contributor

@corinagum corinagum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants