Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Changed
@babel/runtime@7.14.8
botframework-streaming@4.14.1
buffer@6.0.3
core-js@3.15.2
cross-fetch@3.1.4
rxjs@5.5.12
url-search-params-polyfill@8.1.1
@babel/cli@7.14.8
@babel/core@7.14.8
@babel/plugin-transform-runtime@7.14.5
@babel/preset-env@7.14.8
@babel/preset-typescript@7.14.5
@types/jest@26.0.24
@types/jsonwebtoken@8.5.4
@types/node@16.4.0
babel-loader@8.2.2
babel-jest@27.0.6
babel-plugin-istanbul@6.0.0
concurrently@6.2.0
dotenv@10.0.0
event-target-shim@6.0.2
get-port@5.1.1
global-agent@2.2.0
jest@27.0.6
jest-environment-jsdom@27.0.6
jsdom@16.6.0
nock@13.1.1
node-fetch@2.6.1
restify@8.5.1
rimraf@3.0.2
simple-update-in@2.2.0
typescript@4.3.5
webpack@5.45.1
webpack-cli@4.7.2
webpack-stats-plugin@1.0.3
Notably changes
Buffer
frombuffer
package, instead of from globaljest@27
window
objectuuid
will fail because lack of Web Crypto__tests__/setup/setupCrypto.js
Access-Control-Allow-Origin
on the GET/POST, even though it has it in the OPTIONS responseAccess-Control-Allow-Origin
explicitly when running inside jsdomjest.config.js
to transform packages that explicitly use ESMp-defer
) explicitly enforce ESM thru{ "type": "module" }
in theirpackage.json
--silent
option to suppress console log when runningnpm test
.babelrc.js
tobabel.config.json
for modernizationwebpack@5
webpack-visualizer-plugin
towebpack-stats-plugin
process.env.VERSION
is never used in production code, removing it fromDefinePlugin
Tested environment
npm test
directline.js
(bundle)npm link
to Web ChatIntegration tests consists of:
For other browsers, we rely on Web Chat to test them.
Additional context
Jest doesn't like ESM
When running Jest with ESM-enforcing packages, such as
p-defer
, default Jest configuration will fail because it tries to import as ESM while running as CommonJS.In addition to userland code, we also need to transpile
/node_modules/p-defer
while Jest is running Babel on-the-fly. Thus,transformIgnorePatterns
is updated to includep-defer
, which is used in test code.Transpiling on-the-fly
Both
botframework-streaming
andbuffer
package requires us to usebabel-loader
while bundling thru Webpack:botframework-streaming
package.json/browser
point to a monolithic bundle)uuid
and is not ES5-friendly, due to the use of default argumentbuffer