Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test for WebSocket being defined #6

Merged
merged 1 commit into from
Feb 8, 2017
Merged

Fix test for WebSocket being defined #6

merged 1 commit into from
Feb 8, 2017

Conversation

tobybrad
Copy link
Contributor

@tobybrad tobybrad commented Feb 8, 2017

This fixes the initial problem.. but shouldn't WebSocket be an import, perhaps conditional on webSocket:true? It's not clear, as written, how WebSocket ends up in the global scope (by being imported by a different module perhaps?).

@msftclas
Copy link

msftclas commented Feb 8, 2017

Hi @tobybrad, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!


It looks like you're a Microsoft contributor (Toby Bradshaw). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants