Skip to content

Commit

Permalink
Fixed blank inspectors due to new contextIsolation default value (#2321)
Browse files Browse the repository at this point in the history
* Fixed blank inspectors due to new contextIsolation default value in Electron 13

* Added changelog entry
  • Loading branch information
tonyanziano committed Nov 11, 2021
1 parent 0a75699 commit 608f7c2
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 0 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
## Added
- [main] Bumped `electron` to v13.6.1 in PR [2318](https://github.com/microsoft/BotFramework-Emulator/pull/2318)
- [main] Fixed early restify route termination in `replyToActivity` handler in PR [2320](https://github.com/microsoft/BotFramework-Emulator/pull/2320)
- [client] Set `contextIsolation` to `false` in Inspector `<webview>` elements in PR [2321](https://github.com/microsoft/BotFramework-Emulator/pull/2321)

## v4.14.0 - 2021 - 7 - 15
## Added
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -358,6 +358,7 @@ export class Inspector extends React.Component<InspectorProps, InspectorState> {
webView.setAttribute('partition', `persist:${state.botHash}`);
webView.setAttribute('preload', state.inspector.preloadPath);
webView.setAttribute('src', encodeURI(state.inspector.src));
webView.setAttribute('webPreferences', `contextIsolation=no`);
return webView;
}

Expand Down

0 comments on commit 608f7c2

Please sign in to comment.