Assessed PR comments.

microsoft · Nov 29, 2018 · 8154e13 · 8154e13
1 parent dbd646b
commit 8154e13
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 16 deletions.
diff --git a/packages/app/client/src/ui/shell/mdi/documents/documents.tsx b/packages/app/client/src/ui/shell/mdi/documents/documents.tsx
@@ -44,10 +44,6 @@ export interface DocumentsProps {
 }
 
 export class Documents extends React.Component<DocumentsProps> {
-  constructor(props: DocumentsProps) {
-    super(props);
-  }
-
   public render(): JSX.Element[] {
     const { activeDocumentId = '', tabOrder = [], documents = {} } = this.props;
 

diff --git a/packages/app/client/src/ui/shell/mdi/documents/documentsContainer.ts b/packages/app/client/src/ui/shell/mdi/documents/documentsContainer.ts
@@ -36,11 +36,12 @@ import { Documents, DocumentsProps } from './documents';
 import { RootState } from '../../../../data/store';
 
 function mapStateToProps(state: RootState, ownProps: DocumentsProps): DocumentsProps {
+  const { editors } = state.editor;
   return {
     ...ownProps,
-    activeDocumentId: state.editor.editors[ownProps.owningEditor].activeDocumentId,
-    documents: state.editor.editors[ownProps.owningEditor].documents,
-    tabOrder: state.editor.editors[ownProps.owningEditor].tabOrder
+    activeDocumentId: editors[ownProps.owningEditor].activeDocumentId,
+    documents: editors[ownProps.owningEditor].documents,
+    tabOrder: editors[ownProps.owningEditor].tabOrder
   };
 }
 

diff --git a/packages/app/client/src/ui/shell/mdi/mdi.tsx b/packages/app/client/src/ui/shell/mdi/mdi.tsx
@@ -38,10 +38,6 @@ import * as styles from './mdi.scss';
 import { DocumentsContainer } from './documents/documentsContainer';
 
 export class MDIComponent extends React.Component<MDIProps> {
-  constructor(props: MDIProps) {
-    super(props);
-  }
-
   public render(): React.ReactNode {
     const { presentationModeEnabled } = this.props;
     return (

diff --git a/packages/app/client/src/ui/shell/mdi/tabbedDocument/tabbedDocument.tsx b/packages/app/client/src/ui/shell/mdi/tabbedDocument/tabbedDocument.tsx
@@ -42,11 +42,7 @@ export interface TabbedDocumentProps {
 }
 
 export class TabbedDocument extends React.Component<TabbedDocumentProps> {
-  constructor(props: TabbedDocumentProps) {
-    super(props);
-  }
-
-  render() {
+  public render() {
     const { children, documentId, hidden } = this.props;
     return (
       <TabbedDocumentContentWrapper