Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emulator UI: "Split Editor" and "Presentation Mode" icons wrong color for Light Theme #833

Closed
mewa1024 opened this issue Sep 6, 2018 · 0 comments
Closed

Emulator UI: "Split Editor" and "Presentation Mode" icons wrong color for Light Theme #833

mewa1024 opened this issue Sep 6, 2018 · 0 comments
Assignees
@justinwilaby
Labels
Approved Approved by the Triage team Bug Your classic code defect Next-Iteration An approved issue or bug, in the backlog, that is planned for the next iteration P0 Must Fix. Release-blocker

Comments

@mewa1024
Copy link

mewa1024 commented Sep 6, 2018

Build 4.0.262-nightly

In the Light Theme, the icons are white on almost-white:
image

Should be #4A4A4A.
image

Design: https://microsoft-fuse-design.invisionapp.com/d/main/#/console/14907902/310015551/inspect
@mewa1024 mewa1024 added the Bug Your classic code defect label Sep 6, 2018
@vishwacsena vishwacsena added Approved Approved by the Triage team Next-Iteration An approved issue or bug, in the backlog, that is planned for the next iteration P0 Must Fix. Release-blocker labels Sep 6, 2018
justinwilaby pushed a commit that referenced this issue Sep 13, 2018
#833 - Colorized icons according to theme. Themed JSON Viewer
0ea1b42
justinwilaby pushed a commit that referenced this issue Sep 13, 2018
Merge pull request #848 from Microsoft/jwilaby/#833-icon-colors
ad5501b 
#833 - Colorized icons according to theme. Themed JSON Viewer
This was referenced Nov 5, 2022
Open
Open
@snyk-bot snyk-bot mentioned this issue Nov 7, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@justinwilaby justinwilaby

Labels
Approved Approved by the Triage team Bug Your classic code defect Next-Iteration An approved issue or bug, in the backlog, that is planned for the next iteration P0 Must Fix. Release-blocker
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@justinwilaby @vishwacsena @mewa1024