Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emulator: on Mac, opening a .bot file with the Emulator from OS launches Emulator but does not open .bot file #947

Closed
mewa1024 opened this issue Oct 1, 2018 · 4 comments
Closed

Emulator: on Mac, opening a .bot file with the Emulator from OS launches Emulator but does not open .bot file #947

mewa1024 opened this issue Oct 1, 2018 · 4 comments
Assignees
@justinwilaby
Labels
Approved Approved by the Triage team Bug Your classic code defect P0 Must Fix. Release-blocker

Comments

@mewa1024
Copy link

mewa1024 commented Oct 1, 2018

Version

Mac: Emulator_OSX_v4.0.0-preview.40025_40380

Describe the bug

From file browser, opening a .bot file by double-clicking or contextual menu launches the Emulator but does not open the .bot file. The Emulator shows the Welcome tab.

To Reproduce

Steps to reproduce the behavior:

  1. In Finder, go to your bot folder.
  2. Right-click .bot file, and select Emulator (or double-click).
  3. Emulator launches, but no .bot file is open.

Screenshots

image
image

[bug]
@corinagum corinagum added the Bug Your classic code defect label Oct 1, 2018
@sgellock sgellock added the Approved Approved by the Triage team label Oct 4, 2018
@sgellock sgellock added this to the 4.1 milestone Oct 4, 2018
@vishwacsena vishwacsena added v4 and removed v4 labels Oct 9, 2018
@sgellock sgellock added the v4.1 label Oct 9, 2018
@vishwacsena vishwacsena removed this from the 4.1 milestone Oct 9, 2018
@justinwilaby
Copy link
Contributor

I was able to repro this and did see a problem. I'm working on a fix for this now.

justinwilaby pushed a commit that referenced this issue Oct 10, 2018
#947 - Fixed defect when opening a bot file on a mac
1ccf13a
justinwilaby pushed a commit that referenced this issue Oct 10, 2018
Merge branch 'v4' into jwilaby/#947-mac-bot-file-open
7aece0e
justinwilaby pushed a commit that referenced this issue Oct 10, 2018
Merge pull request #970 from Microsoft/jwilaby/#947-mac-bot-file-open
e1b2455 
#947 - Fixed defect when opening a bot file on a mac
@justinwilaby
Copy link
Contributor

Fixed by #970

@mewa1024 mewa1024 reopened this Oct 13, 2018
@mewa1024
Copy link
Author

@justinwilaby I'm still having this problem on the Mac build from October 12: 4.0.0-preview-one-off.
Double-clicking .bot file launches Emulator, but no .bot file is open:

screen shot 2018-10-12 at 7 52 23 pm 2

screen shot 2018-10-12 at 7 52 41 pm 2

@sgellock sgellock added the P0 Must Fix. Release-blocker label Oct 15, 2018
@justinwilaby
Copy link
Contributor

I have confirmed this is fixed on 4.0.50000

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@justinwilaby justinwilaby

Labels
Approved Approved by the Triage team Bug Your classic code defect P0 Must Fix. Release-blocker
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@sgellock @justinwilaby @tonyanziano @corinagum @vishwacsena @mewa1024