View menu text scrub #1053
Closed
View menu text scrub #1053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1145
💛 - Coveralls |
tonyanziano
approved these changes
Oct 29, 2018
justinwilaby
suggested changes
Oct 30, 2018
| @@ -235,16 +235,7 @@ export const AppMenuBuilder = new class AppMenuBuilderImpl implements AppMenuBui | |||
| return { | |||
| label: 'View', | |||
| submenu: [ | |||
| { | |||
| label: 'Explorer', | |||
| click: () => mainWindow.commandService.remoteCall(SharedConstants.Commands.UI.ShowExplorer) | |||
There was a problem hiding this comment.
Are there any more calls to these commands? If not, let's remove the command registrations too.
| @@ -3,20 +3,20 @@ | |||
| object-assign | |||
There was a problem hiding this comment.
How did this get in there?
There was a problem hiding this comment.
This diff was showing up for me as well every time I pulled and rebuilt the package, but I never checked it in. This must be that same change. I have no idea how it gets generated though.
|
Also, once you resolve all the changes you might want to re-submit this PR into |
|
@tonyanziano @justinwilaby Thanks guys, let me redo this PR with corrections. :) |
|
Closing this in favor of #1061 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #820
(Low priority PR as this is a 4.2 change)