Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge v4.2.1 feature branch into master #1188

Merged
merged 6 commits into from
Dec 18, 2018
Merged

Conversation

tonyanziano
Copy link
Contributor

I rebased to clean up commit history.

@coveralls
Copy link

coveralls commented Dec 18, 2018

Pull Request Test Coverage Report for Build 1593

  • 77 of 82 (93.9%) changed or added relevant lines in 5 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.2%) to 57.607%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/app/main/src/appMenuBuilder.ts 58 63 92.06%
Files with Coverage Reduction New Missed Lines %
packages/app/main/src/utils/getThemes.ts 1 90.0%
packages/app/main/src/utils/loadSettings.ts 1 79.07%
Totals Coverage Status
Change from base Build 1583: 0.2%
Covered Lines: 4867
Relevant Lines: 7598

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants