Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some additional keyboard bindings/improvements #1202

Closed
wants to merge 10 commits into from
Closed

Conversation

cwhitten
Copy link
Member

(CMD/CTRL) + W now closes the active tab if there is one, currently the bindings close the application entirely.
(CMD/CTRL) + O now prompts the user to select a .bot file to open. currently there is no behavior with this binding.
(CMD/CTRL) + N now opens the new bot configuration modal. currently there is no behavior with this binding.
Bugfixes/Improvements:

When a conversation tab is closed and opened again via an open dialog(s), the user receives an error about the bot already being open. To achieve this behavior successfully it requires a click on the correct Endpoint item to re-open the conversation tab. This change makes it so that the tab is automatically re-opened without the error when the user opens an already open bot with an open dialog.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1658

  • 11 of 17 (64.71%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 58.273%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/app/client/src/ui/shell/mdi/tabBar/tabBar.tsx 1 7 14.29%
Totals Coverage Status
Change from base Build 1652: -0.02%
Covered Lines: 5026
Relevant Lines: 7761

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants