Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1237 - added new copy and updated functionality #1238

Merged
merged 5 commits into from
Jan 17, 2019

Conversation

justinwilaby
Copy link
Contributor

@justinwilaby justinwilaby commented Jan 16, 2019

fixes #1237
image

image

@coveralls
Copy link

coveralls commented Jan 16, 2019

Pull Request Test Coverage Report for Build 1835

  • 23 of 25 (92.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.003%) to 61.838%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/app/client/src/ui/helpers/activeBotHelper.ts 15 17 88.24%
Totals Coverage Status
Change from base Build 1827: 0.003%
Covered Lines: 5458
Relevant Lines: 7912

💛 - Coveralls

@cwhitten
Copy link
Member

@justinwilaby can you attach a screenshot of the services pane with the changes that @mewa1024 can look at?

tonyanziano
tonyanziano previously approved these changes Jan 17, 2019
Copy link
Contributor

@tonyanziano tonyanziano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Connect to a bot without a .bot file - revisions
4 participants