catch error when restarting conversation #1250
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-b-r-o-w-n
requested review from
compulim,
corinagum,
cwhitten,
justinwilaby and
tonyanziano
as code owners
|
Why don't we just land https://github.com/Microsoft/BotFramework-DirectLineJS/pull/133/files ? |
justinwilaby
suggested changes
Jan 24, 2019
@cwhitten I'm not sure that change is warranted yet. We should consider the implications of that change. What I'm concerned about is that the thrown error has existed since direct line was first pushed, so I'm worried about missing something regarding why it's there. |
Pull Request Test Coverage Report for Build 1921
💛 - Coveralls |
a-b-r-o-w-n
force-pushed
the
fix-restart-conversation
branch
from
8685ac5
to
522e53a
Compare
fixes #1241 This should probably be addressed in direct line, but it's not immediately clear why the error is being thrown in the first place.
a-b-r-o-w-n
force-pushed
the
fix-restart-conversation
branch
from
522e53a
to
3ee2551
Compare
| @@ -93,6 +93,20 @@ interface EmulatorProps { | |||
| url?: string; | |||
| } | |||
|
|
|||
| export function endConversation(directLine: any): void { | |||
There was a problem hiding this comment.
Is this expected to be used by other operations outside this class? I'm curious why this went from private to an exported function. My comment previously was regarding a consideration given to a private static declaration for this function.
This was referenced Nov 5, 2022
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1241
This should probably be addressed in direct line, but it's not
immediately clear why the error is being thrown in the first place.