Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Allow the Emulator user to specify a User ID (#1422)" #1429

Merged
merged 1 commit into from Apr 15, 2019

Conversation

justinwilaby
Copy link
Contributor

This reverts commit 2c6a4cf.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 2398

  • 5 of 11 (45.45%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.03%) to 55.463%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/app/client/src/ui/editor/emulator/emulator.tsx 5 11 45.45%
Files with Coverage Reduction New Missed Lines %
packages/app/client/src/ui/editor/emulator/emulator.tsx 1 73.37%
Totals Coverage Status
Change from base Build 2390: -0.03%
Covered Lines: 4897
Relevant Lines: 8320

💛 - Coveralls

@justinwilaby justinwilaby merged commit ffcda76 into master Apr 15, 2019
@justinwilaby justinwilaby deleted the revert-1422-feature/southworks/choose-userId branch April 15, 2019 23:10
@JuanAr
Copy link
Collaborator

JuanAr commented Apr 16, 2019

@justinwilaby should we reopen #1344?

@cwhitten
Copy link
Member

Hi @JuanAr - Justin's in-flight work in #1400 had problems reconciling with some of the changes made in this diff, so we reverted it in the hopes that when his branch lands @Aliandi can reissue the pull request against master again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants