Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#1846] Fixed a11y focus issue with key / value pairs in service editor. #1924

Merged
merged 1 commit into from Oct 10, 2019
Merged

[#1846] Fixed a11y focus issue with key / value pairs in service editor. #1924

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Expand Up @@ -68,6 +68,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- [1917](https://github.com/microsoft/BotFramework-Emulator/pull/1917)
- [1918](https://github.com/microsoft/BotFramework-Emulator/pull/1918)
- [1921](https://github.com/microsoft/BotFramework-Emulator/pull/1921)
- [1923](https://github.com/microsoft/BotFramework-Emulator/pull/1923)
- [1924](https://github.com/microsoft/BotFramework-Emulator/pull/1924)

- [client] Fixed an issue with the transcripts path input inside of the resource settings dialog in PR [1836](https://github.com/microsoft/BotFramework-Emulator/pull/1836)
- [client] Implemented HTML app menu for Windows in PR [1893](https://github.com/microsoft/BotFramework-Emulator/pull/1893)
Expand Down
11 changes: 11 additions & 0 deletions ...src/ui/shell/explorer/servicesExplorer/connectedServiceEditor/connectedServiceEditor.scss
View file
Open in desktop
Expand Up @@ -63,6 +63,17 @@ ul.kv-pair-container {
> * {
width: 100%;
}

// key
> div {
margin-right: 4px;
}

// value
> div + div {
margin-right: 0;
margin-left: 4px;
}
}

input[disabled] {
Expand Down
4 changes: 2 additions & 2 deletions packages/app/client/src/ui/shell/explorer/servicesExplorer/connectedServiceEditor/kvPair.tsx
View file
Open in desktop
Expand Up @@ -63,8 +63,8 @@ export class KvPair extends Component<KvPairProps, KvPairState> {
return (
<div>
<span className={styles.header}>
<span>Key</span>
<span>Value</span>
<label>Key</label>
<label>Value</label>
</span>
<ul className={styles.kvPairContainer}>
{kvPairs.map((pair, index) => (
Expand Down