[ISSUE#1910][MAS4.2.10][Focus Order - Connect the bot] In JSON tab, the focus goes on the hidden controls #1982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denscollo
requested review from
a-b-r-o-w-n,
compulim,
corinagum,
cwhitten and
tonyanziano
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #1910
Description
Fixes how the focus goes to the three hidden buttons on the JSON Inspector pane.
Changes made
In the Inspector component, we added two attributes to the accessory buttons when these are disabled. These attributes are
TabIndex=-1andaria-hidden=true. This way, the focus won't go to these buttons while they are disabled, only in Debug Mode when they get enabled.Additionally, we noticed that this issue was happening on windows as well. The same solution applies to the three platforms, Windows, MacOS, and Linux.
Testing
In the following images, you can see how the focus goes to the accessory buttons only in Debug Mode when they are enabled: